Addons: make it work on invalid URLs #12372
Merged
+47
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Aug 18, 2025
| # We do allow hitting this URL without a valid version. | ||
| # This is the same case than sending `?url=` with a partial match | ||
| # (eg. invalid URL path). | ||
| version = project.versions.filter(slug=version_slug).first() |
There was a problem hiding this comment.
This should probably check if the version slug is empty instead. Given a wrong version and not version at all isn't the same.
There was a problem hiding this comment.
We aren't doing anything different if the version slug is invalid/empty when the ?url= attribute is passed either. This matches that behavior when using ?version= attribute.
I'm happy to discuss behaving differently in those cases if we want that, but I want to move forward with this PR here and work on that different behavior in a different one.
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12371